Overriding DefaultChartTheme: safe or not?

[andrey_nado]

Hi, JasperReports team! Thanks for great library.

I need my custom chart theme, but my only goal is to create special pie charts. Other functionality should be pretty standard.

I decided to extend standard class net.sf.jasperreports.engine.fill.DefaultChartTheme and override createPie3DChart and createPieChart methods. They both are protected, thanks!

My question: are these two methods the part of contract of DefaultChartTheme class? Will this class be dramatically changed in the future versions of JasperReports and createPie3DChart and createPieChart methods disappear or change their signatures? Is my approach safe and correct enough?

Regards,

Andrey

[lucianc]

While there's no firm guarantee that the method signatures won't change, that probably will not happen and we'll take into consideration such customizations.

The problem I see here is that you had to copy (and modify) entire methods from DefaultChartTheme, and if we change something in the methods your theme will not see the change.  Ideally we should provide finer grained extension points.

Regards,

Lucian

[andrey_nado]

In my case I need MultiplePiePlot charts and only legal way is to use chart themes. It would be great if I have a possibility to customize JFreeChart instantiation not by using themes.

 

Finer grained extension points would be great too.